Skip to content

NO-JIRA: Add verify job for manifest-gen enabled CAPI repositories #71392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RadekManak wants to merge 1 commit into from
Closed

NO-JIRA: Add verify job for manifest-gen enabled CAPI repositories #71392

RadekManak wants to merge 1 commit into from

Conversation

@RadekManak
Copy link
Contributor

@RadekManak RadekManak commented Nov 14, 2025

Adds presubmit for generic verify target in CAPI repositories. Currently, we want to verify that generated manifests are updated.

Requires PRs with verify target in openshift/Makefile
TODO:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 14, 2025

@RadekManak: This pull request explicitly references no jira issue.

Details

In response to this:

Adds presubmit for generic verify target in CAPI repositories. Currently, we want to verify that generated manifests are updated.

Requires PRs with verify target in openshift/Makefile
TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from chrischdi and damdo November 14, 2025 15:34
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RadekManak
Once this PR has been reviewed and has the lgtm label, please assign elfosardo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 14, 2025

@RadekManak, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: [invalid ci-operator config: invalid configuration: tests[9] has no type, you may want to specify 'container' for a container based test, invalid ci-operator config: invalid configuration: tests[11] has no type, you may want to specify 'container' for a container based test, invalid ci-operator config: invalid configuration: tests[8] has no type, you may want to specify 'container' for a container based test, invalid ci-operator config: invalid configuration: tests[4] has no type, you may want to specify 'container' for a container based test]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2025

@RadekManak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-operator-config-metadata a7c8874 link true /test ci-operator-config-metadata
ci/prow/ci-operator-config a7c8874 link true /test ci-operator-config
ci/prow/check-gh-automation a7c8874 link true /test check-gh-automation
ci/prow/generated-config a7c8874 link true /test generated-config
ci/prow/ci-operator-registry a7c8874 link true /test ci-operator-registry
ci/prow/openshift-image-mirror-mappings a7c8874 link true /test openshift-image-mirror-mappings

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 14, 2025

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2025
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 29, 2025

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 29, 2025
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2026

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jan 13, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo damdo mentioned this pull request Jan 15, 2026
Closed
@damdo
Copy link
Member

damdo commented Jan 15, 2026

@RadekManak should we revive this?

This was referenced Jan 15, 2026
Merged
Merged
Merged
Merged
Closed
Merged
@RadekManak
Copy link
Contributor Author

RadekManak commented Jan 15, 2026

/reopen
/remove-lifecycle rotten

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2026

@RadekManak: Failed to re-open PR: state cannot be changed. The capi-verify branch was force-pushed or recreated.

Details

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 15, 2026
@RadekManak
Copy link
Contributor Author

RadekManak commented Jan 15, 2026

Reopened as #73565

@RadekManak RadekManak mentioned this pull request Jan 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@damdo damdo Awaiting requested review from damdo

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RadekManak @openshift-ci-robot @openshift-bot @damdo